Raul Lazar

Observation:

Until version... at least 4.7.8* and how many version after, I don't know (because I only notice now, at 4.8.7) the structure of folders used for profile picture uploads was in this format:

/file/pic/user/year/month/pic.xxx

now is:

/file/pic/user/pic.xxx

so practicaly, no more year and month.

Problem:
The new structure format, in my opinion and in a logical thinking... it's not good at all and can cause problems on long term.

Why?
Because uploading all the profile pictures in the same folder, especially on big communities, makes that folder huge (many file in a single folder). For example, on my server, that folder, already has more than 65.000 photos and any FTP/SFTP client barely opens/list it.

Others:
I've saw that timeline photos and other are still in old style (year/month), which is good.

*As far as I can see, the old format stopped for me in 06.2021 (the last folder) but I don't know which version I had then (not to old because, I usually update when a new version appears). I mentioned an older version above, because that version I had on a test/development server (which was not updated from initial install) and I can confirm it was that way (the old format).

Be the first person to like this.
JohnJr

Good find...

I wonder if there is a reason.  I don't think storing long file paths takes up alot which I know would be required to not only show the image but also delete it if the user cancels their account or downloads it.

Be the first person to like this.
Paris

It's still using /file/pic/user/2021/10/file.xxx so everythings fine.

Latest version. 4.8.7.

Same with the photo's directory or any other.

 

 

Last update on October 25, 2021 by Paris.
Be the first person to like this.
Raul Lazar

I don't know where you saw that... because, it doesn't. Not even on your demo here: https://v4.phpfox.com/phpfoxdemo

<div class="img-wrapper built-status built-status-done" data-core-image-user="242"><img src="https://v4.phpfox.com/PF.Base/file/pic/user/f3df3632d40a81389408961d10db49ff_200_square.png?t=61768ff054600"; alt="phpFox Demo" class="_image_200 image_deferred  profile_user_image built no_image" no_link="1"></div>

see: https://v4.phpfox.com/PF.Base/file/pic/user/f3df3632d40a81389408961d10db49ff_200_square.png?t=61768ff054600%22

Same "story" on my website and on a clean install. Yes, any other photos works, just the profile picture...

 

Last update on October 25, 2021 by Raul Lazar.
Be the first person to like this.
Raul Lazar

This printscreen and the copy/paste above, it's from your demo. 

Be the first person to like this.
Paris
#cccccc;padding:5px 10px;"You are correct. I see exactly what happened But however this will only impact shared hosting. 

For VPS and dedicated it'll be fine because it's 4,294,967,295 == unlimited.

Be the first person to like this.
Raul Lazar

Maybe for VPS and dedicated are okei, as a system... but if I want to manually check that folder (to, I don't know, for example, delete some photos), any FTP/SFTP program will just freeze because it has to list so many files (even now, with 65.000, I have to wait quite long). It won't be long before it will be impossible to list it because a simple math: just 35.000 users x 4 photos (for one profile photo, because it will create more sizes)... will result in 140.000 photos and so on..

In my opinion, the old format with year and month was more logical and clean/well structured. It will be nice if the old format "comes back".

Thanks! 

Be the first person to like this.
Raul Lazar

Quick update: I've got an anwer on GitHub, it was added to the 4.8.8 milestone. Thanks!